Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for node-sass 3.4.2 update #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix tests for node-sass 3.4.2 update #19

wants to merge 3 commits into from

Conversation

JohnAlbin
Copy link
Member

Node-sass 3.4.2 is out and node-sass-import-once's tests fail. See #22

In this PR I've fixed node-sass-import-once's tests so they pass.

I also move the tests from a tests folder to just test since mocha defaults to looking for that directory name.

@JohnAlbin JohnAlbin changed the title Node sass update Fix tests for node-sass 3.4.2 update Nov 15, 2015
This was referenced Nov 19, 2015
Open
Open
@JohnAlbin JohnAlbin mentioned this pull request Nov 26, 2015
Closed
@Snugug
Copy link
Member

Snugug commented Feb 21, 2016

Merge conflicts :(

@JohnAlbin
Copy link
Member Author

Rebased! And fixed the new test which was also broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
under consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnAlbin @Snugug